Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tuning visibility in CLI #4827

Merged
merged 2 commits into from
Jul 2, 2018
Merged

Fix tuning visibility in CLI #4827

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e75403b
Fix tuning visibility in CLI
jefferai Jun 25, 2018
bf2740d
Merge branch 'master' into fix-listing-visibility-cli
vishalnayak Jul 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vault/logical_system.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3709,6 +3709,7 @@ func sanitizeMountPath(path string) string {

func checkListingVisibility(visibility ListingVisibilityType) error {
switch visibility {
case ListingVisibilityDefault:
case ListingVisibilityHidden:
case ListingVisibilityUnauth:
default:
Expand Down
4 changes: 3 additions & 1 deletion vault/mount.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ const (
type ListingVisibilityType string

const (
// ListingVisibilityDefault is the default value for listing visibility
ListingVisibilityDefault ListingVisibilityType = ""
// ListingVisibilityHidden is the hidden type for listing visibility
ListingVisibilityHidden ListingVisibilityType = ""
ListingVisibilityHidden ListingVisibilityType = "hidden"
// ListingVisibilityUnauth is the unauth type for listing visibility
ListingVisibilityUnauth ListingVisibilityType = "unauth"
)
Expand Down
8 changes: 5 additions & 3 deletions website/source/api/system/mounts.html.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ This endpoint enables a new secrets engine at the given path.
that will not be HMAC'd by audit devices in the response data object.

- `listing_visibility` `(string: "")` - Speficies whether to show this mount
in the UI-specific listing endpoint.
in the UI-specific listing endpoint. Valid values are `"unauth"` or
`"hidden"`. If not set, behaves like `"hidden"`.

- `passthrough_request_headers` `(array: [])` - Comma-separated list of headers
to whitelist and pass from the request to the backend.
Expand Down Expand Up @@ -229,8 +230,9 @@ This endpoint tunes configuration parameters for a given mount point.
list of keys that will not be HMAC'd by audit devices in the response data
object.

- `listing_visibility` `(string: "")` - Speficies whether to show this mount
in the UI-specific listing endpoint. Valid values are `"unauth"` or `""`.
- `listing_visibility` `(string: "")` - Speficies whether to show this mount in
the UI-specific listing endpoint. Valid values are `"unauth"` or `"hidden"`.
If not set, behaves like `"hidden"`.

- `passthrough_request_headers` `(array: [])` - Comma-separated list of headers
to whitelist and pass from the request to the backend.
Expand Down