UI - fix kv object so that falsey values don't get coerced to empty strings #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisdair
previously approved these changes
Jul 23, 2018
ui/tests/unit/lib/kv-object-test.js
Outdated
| let expected = JSON.stringify(output, null, 2); | ||
| let data = KVObject.create({ content: [] }).fromJSON(input); | ||
| let result = data.toJSONString(includeBlanks); | ||
| assert.deepEqual(result, expected, 'has expected output string'); |
There was a problem hiding this comment.
Unless I'm misreading this, we're comparing two strings here, so this can be assert.equal.
(I was initially concerned that comparing JSON.stringify output was invalid due to being non-deterministic, but that's not actually true!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on master, if you
You'll see that your false-y values get coerced to empty strings. This PR changes the kv object array proxy to check for existence of the value instead of checking its false-y-ness.