Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for writing config attribute 'max_retries' for aws auth method #4980

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Fix for writing config attribute 'max_retries' for aws auth method #4980

merged 1 commit into from
Jul 24, 2018

Conversation

andrejvanderzee
Copy link
Contributor

After a client config is created for the AWS auth method, we can't change max_retries without first deleting the client config. Because, for existing configs max_retries the config is not pushed to backend storage:

$ vault write auth/team7/aws/k8s/node/config/client max_retries=20
Success! Data written to: auth/team7/aws/k8s/node/config/client
$ vault read auth/team7/aws/k8s/node/config/client
Key                           Value
---                           -----
access_key                    n/a
endpoint                      n/a
iam_endpoint                  n/a
iam_server_id_header_value    n/a
max_retries                   10
sts_endpoint                  n/a

Please merge this fix so we can delete our workaround.

@jefferai
Copy link
Member

Thanks!

@jefferai jefferai merged commit 2b34bda into hashicorp:master Jul 24, 2018
@jefferai jefferai added this to the 0.10.4 milestone Jul 24, 2018
@andrejvanderzee
Copy link
Contributor Author

andrejvanderzee commented Jul 24, 2018

That was a quick merge, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants