Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mount_path and mount_type to group lookups #5074

Merged
merged 2 commits into from
Aug 9, 2018

Conversation

uepoch
Copy link
Contributor

@uepoch uepoch commented Aug 8, 2018

Address #5073

@uepoch uepoch changed the title Add mount_path and mount_type to group lookups Issue: #5073 Add mount_path and mount_type to group lookups Aug 8, 2018
@@ -297,6 +297,11 @@ func (i *IdentityStore) handleGroupReadCommon(group *identity.Group) (*logical.R
aliasMap["merged_from_canonical_ids"] = group.Alias.MergedFromCanonicalIDs
aliasMap["creation_time"] = ptypes.TimestampString(group.Alias.CreationTime)
aliasMap["last_update_time"] = ptypes.TimestampString(group.Alias.LastUpdateTime)

if mountValidationResp := i.core.router.validateMountByAccessor(group.Alias.MountAccessor); mountValidationResp != nil {
aliasMap["mount_path"] = mountValidationResp.MountPath
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the corresponding entries from the earlier assignment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jefferai jefferai added this to the 0.10.5 milestone Aug 8, 2018
@jefferai jefferai merged commit d287ed4 into hashicorp:master Aug 9, 2018
@jefferai
Copy link
Member

jefferai commented Aug 9, 2018

Thanks!

@uepoch uepoch deleted the fix-group-alias-mount-path branch August 10, 2018 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants