-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logical/aws: Harden WAL entry creation #5202
Merged
Merged
Commits on Aug 27, 2018
-
logical/aws: Harden WAL entry creation
If AWS IAM user creation failed in any way, the WAL corresponding to the IAM user would get left around and Vault would try to roll it back. However, because the user never existed, the rollback failed. Thus, the WAL would essentially get "stuck" and Vault would continually attempt to roll it back, failing every time. A similar situation could arise if the IAM user that Vault created got deleted out of band, or if Vault deleted it but was unable to write the lease revocation back to storage (e.g., a storage failure). This attempts to harden it in two ways. One is by deleting the WAL log entry if the IAM user creation fails. However, the WAL deletion could still fail, and this wouldn't help where the user is deleted out of band, so second, consider the user rolled back if the user just doesn't exist, under certain circumstances. Fixes hashicorp#5190
Configuration menu - View commit details
-
Copy full SHA for 7c8c3f5 - Browse repository at this point
Copy the full SHA 7c8c3f5View commit details
Commits on Aug 28, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 959c478 - Browse repository at this point
Copy the full SHA 959c478View commit details -
Fix segfault in expiration unit tests
TestExpiration_Tidy was passing in a leaseEntry that had a nil Secret, which then caused a segfault as the changes to revokeEntry didn't check whether Secret was nil; this is probably unlikely to occur in real life, but good to be extra cautious.
Configuration menu - View commit details
-
Copy full SHA for 511a89d - Browse repository at this point
Copy the full SHA 511a89dView commit details
Commits on Aug 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 03a8d3f - Browse repository at this point
Copy the full SHA 03a8d3fView commit details
Commits on Sep 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7267c9e - Browse repository at this point
Copy the full SHA 7267c9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ce5eb8 - Browse repository at this point
Copy the full SHA 2ce5eb8View commit details
Commits on Sep 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 77bd77e - Browse repository at this point
Copy the full SHA 77bd77eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.