Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logical/aws: Harden WAL entry creation #5202

Merged
merged 7 commits into from
Sep 27, 2018

Commits on Aug 27, 2018

  1. logical/aws: Harden WAL entry creation

    If AWS IAM user creation failed in any way, the WAL corresponding to the
    IAM user would get left around and Vault would try to roll it back.
    However, because the user never existed, the rollback failed. Thus, the
    WAL would essentially get "stuck" and Vault would continually attempt to
    roll it back, failing every time. A similar situation could arise if the
    IAM user that Vault created got deleted out of band, or if Vault deleted
    it but was unable to write the lease revocation back to storage (e.g., a
    storage failure).
    
    This attempts to harden it in two ways. One is by deleting the WAL log
    entry if the IAM user creation fails. However, the WAL deletion could
    still fail, and this wouldn't help where the user is deleted out of
    band, so second, consider the user rolled back if the user just doesn't
    exist, under certain circumstances.
    
    Fixes hashicorp#5190
    joelthompson committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    7c8c3f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2018

  1. Configuration menu
    Copy the full SHA
    959c478 View commit details
    Browse the repository at this point in the history
  2. Fix segfault in expiration unit tests

    TestExpiration_Tidy was passing in a leaseEntry that had a nil Secret,
    which then caused a segfault as the changes to revokeEntry didn't check
    whether Secret was nil; this is probably unlikely to occur in real life,
    but good to be extra cautious.
    joelthompson committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    511a89d View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2018

  1. Fix potential segfault

    Missed the else...
    joelthompson committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    03a8d3f View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2018

  1. Respond to PR feedback

    joelthompson committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    7267c9e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ce5eb8 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. Configuration menu
    Copy the full SHA
    77bd77e View commit details
    Browse the repository at this point in the history