UI - don't coerce JSON input to an Object #5271
Conversation
| export default Ember.ArrayProxy.extend({ | ||
| fromJSON(json) { | ||
| const contents = Object.keys(json || []).map(key => { | ||
| if (json && typeOf(json) !== 'object') { | ||
| throw new Error('Vault expects data to be formatted as an JSON object.'); |
There was a problem hiding this comment.
Should we explain more than this? I'm afraid they're going to alter it enough so it gets accepted and then run into the same issue now where the keys are array indexes
There was a problem hiding this comment.
I was thinking this is already the advanced mode so there would be some idea of what they're doing. The index thing was happening because we were using Object.keys on an array, but now we short circuit that, so it would take quite a bit of fiddling to get back there.
What sort of extra explanation were you thinking? Maybe: "The input is valid JSON, but Vault requires the top-level structure to be a JSON Object and currently it is not." Or something like that?
|
Going to merge to get in for the release - we can still tweak the error message |
Previously, we would Object.keys and then loop over the items, assuming the input was an object. Turns out that didn't work so well.
Now, if there is input, and it's not an object, we show an error and disable submission of the form.
The current state with JSON linting errors:
Additionally, we now will show this if the input is valid JSON, but not an object (you can't see the whole editor here, but the top level is an array, not an object):
Fixes #5153