Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow most parts of Vault's logging to have its level changed on-the-fly #5280

Merged
merged 2 commits into from
Sep 5, 2018

Conversation

jefferai
Copy link
Member

@jefferai jefferai commented Sep 5, 2018

I've tested this out and it works well. There's currently no way to clean loggers from the slice but that should be fine, at least for now. This doesn't currently affect plugins since we don't have a call that can go across the logical/plugin interface.

@jefferai jefferai added this to the 0.11.1 milestone Sep 5, 2018
@@ -152,7 +152,7 @@ func (c *ServerCommand) Flags() *FlagSets {
f.StringVar(&StringVar{
Name: "log-level",
Target: &c.flagLogLevel,
Default: "info",
Default: "(not set)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend defining a constant for this since it is coupled to logic below further down.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew someone was going to point that out.

@jefferai jefferai merged commit d3edc47 into master Sep 5, 2018
@jefferai jefferai deleted the jit-logging-level branch September 5, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants