Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - auth form prefer pathed methods #5281

Merged
merged 1 commit into from
Sep 5, 2018
Merged

UI - auth form prefer pathed methods #5281

merged 1 commit into from
Sep 5, 2018

Conversation

meirish
Copy link
Contributor

@meirish meirish commented Sep 5, 2018

Since we moved fetching unauthed methods into the component with the addition of namespaces, the url transition would potentially fire before the ajax request was complete which lead to the UI always defaulting to ?with=token if you didn't input a query param up front.

This PR fixes the auth form so that it will do this transition after the ajax request has settled.

Fixes #5274

@meirish meirish requested review from a team September 5, 2018 19:19
@meirish meirish modified the milestones: 0.11.2, 0.11.1 Sep 5, 2018
@meirish meirish merged commit 6f30930 into master Sep 5, 2018
@meirish meirish deleted the ui-login-default branch September 5, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login page redirect to "Other" method
1 participant