Add ability to configure the NotBefore property of certificates in role api #5325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-boulin
changed the title
|
Close pull request, need to relaunch CI |
chrishoffman
reviewed
Oct 1, 2018
builtin/logical/pki/path_roles.go
Outdated
| @@ -286,6 +286,11 @@ for "generate_lease".`, | |||
| Type: framework.TypeBool, | |||
| Description: `Mark Basic Constraints valid when issuing non-CA certificates.`, | |||
| }, | |||
| "not_before": &framework.FieldSchema{ | |||
| Type: framework.TypeInt, | |||
There was a problem hiding this comment.
Can you switch this to TypeDuration which will require some other changes in storage. See max_ttl for an example of a TypeDuration field.
chrishoffman
reviewed
Oct 1, 2018
kalafut
reviewed
Oct 2, 2018
builtin/logical/pki/path_roles.go
Outdated
| "not_before": &framework.FieldSchema{ | ||
| Type: framework.TypeDurationSecond, | ||
| Default: 30, | ||
| Description: `The duration before now the cert need to be created / sign.`, |
…he NotBefore datetime on the cert
meirish
reviewed
Oct 2, 2018
| @@ -104,6 +104,11 @@ export default DS.Model.extend({ | |||
| basicConstraintsValidForNonCA: attr('boolean', { | |||
| label: 'Mark Basic Constraints valid when issuing non-CA certificates.', | |||
| }), | |||
| notBeforeDuration: attr({ | |||
| label: 'Not Before Duration', | |||
There was a problem hiding this comment.
You don't have to have this line as it will "humanize" the attribute name, but fine to leave it in.
chrishoffman
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction of #4639