Added role-option max_sts_ttl to cap TTL for AWS STS credentials. #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelthompson
suggested changes
Oct 11, 2018
builtin/logical/aws/path_roles.go
Outdated
| } | ||
|
|
||
| maxSTSTTL := time.Duration(maxSTSTTLRaw.(int)) * time.Second | ||
| if roleEntry.DefaultSTSTTL > 0 && roleEntry.DefaultSTSTTL > maxSTSTTL { |
There was a problem hiding this comment.
Two things:
First,m I think you should also test if maxSTSTL > 0. The reason is that, let's say a user has a max_sts_ttl of 3600 and a default_sts_ttl of 1200. Then, the user wants to remove the max_sts_ttl. That could be done by explicitly setting max_sts_ttl to 0, but then it would trip this check.
Second, you should probably move this check to after this if block. Imagine a user first sets max_sts_ttl to 1200, then in a second request, sets default_sts_ttl to 1800. That should probably also fail out, but I don't think it would.
|
@joelthompson Understood and implemented your suggestions (check for > 0 and moved sanity check outside if-block). |
jefferai
reviewed
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for ability to cap TTL by setting
max_sts_ttlon the role, like described here:#5286