-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI - support for kv v2 #5547
Merged
UI - support for kv v2 #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yRecord, and version find working
…el creation so we're always directly manipulating a model
…assed attributes are non-null
// , Would you mind having the UI degrade gracefully in the event that kv2/data/mysecret is authorized, but kv2/metadata/mysecret is not? This ended up frustrating us for a while, until I took a closer look at the kv2 docs and network connections of the Vault UI. More details here, happy to make a PR if desired: https://groups.google.com/forum/#!topic/vault-tool/lpaoopCzOQc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for viewing versions, delete, undelete, and destroy of versions. Adds contextual menus for v1 and v2 kv secrets.
Changes were previously reviewed in PRs to ui-kv-v2 branch.
fixes #5373