Fix two problems with entity alias updating #5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #5729 (comment) for details Fixes #5729
vishalnayak
changed the title
briankassouf
pushed a commit
that referenced
this pull request
Nov 9, 2018
Fix two problems with entity alias updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
#5729 (comment)
for details
Fixes #5729
TODO:
-- Remove comments [Done]
-- Fix tests [No test errors]
-- Does group handling suffer from the same problem? [No]
-- Merging behavior -- should we merge or simply error out? See discussion in the related ticket. [Discussion deferred]
-- We really should ensure that no upsert function ever does a query, or does so very carefully, it will likely always be against stale data [Noted]