Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icon is too big #172

Closed
nkkowa opened this issue Nov 21, 2022 · 2 comments · Fixed by #174
Closed

New icon is too big #172

nkkowa opened this issue Nov 21, 2022 · 2 comments · Fixed by #174

Comments

@nkkowa
Copy link

nkkowa commented Nov 21, 2022

The new icon is a bit big and doesn't line up well with other icons. Perhaps standardize with the spacing from the Terraform extension.

image

@radeksimko
Copy link
Member

radeksimko commented Nov 21, 2022

Hi @nkkowa
Unfortunately this is a side effect of what I'd consider a bug in VS Code, where extension-contributed icons are treated differently from the builtin ones. I originally raised this in microsoft/vscode#154492 but it seems that VS Code folks aren't too keen to address that.

The Terraform icon is actually built into seti-ui (library used by VS Code to render icons which otherwise aren't provided by extensions), whereas the HCL icon is provided by the HCL extension.

I tried to play with various different paddings and margins in the SVG, but I wasn't able to align it in any way. I think the best course of action would therefore be contributing the HCL icon into seti-ui, so they both use the same styling rules.

@radeksimko
Copy link
Member

btw. We could also contribute Packer icon to seti, which was the context of the original PR as submitted by @bmalehorn
#151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants