Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon: add icon for HCL files #151

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

bmalehorn
Copy link
Contributor

I work in packer files on a regular basis, and it bothered me that these don't have a file icon. Add a file icon, downloaded from https://www.hashicorp.com/brand:

before after (dark) after (light)
image image image

@bmalehorn bmalehorn requested a review from a team as a code owner September 13, 2022 18:26
@hashicorp-cla
Copy link

hashicorp-cla commented Sep 13, 2022

CLA assistant check
All committers have signed the CLA.

@jpogran
Copy link
Contributor

jpogran commented Sep 15, 2022

Thanks for the contribution @bmalehorn! We purposely didn't include an icon until we got a better idea of which products people would use with this extension.

It's also not that common for extensions to provide icons, that's usually theme/icon packs area. This allows users to pick and choose which icons according to their desire.

That being said, this extension is meant for any product that uses the HCL extension, so I like that your choice uses the company logo. Having a Packer specific icon for Packer files would make sense, but we did not want to commit to any one direction at that time.

We'll review this shortly and see if we can merge this as is and change the icons later without much to do, or that we have to make the decision one way or another right now.

@jpogran jpogran merged commit d0e8ac9 into hashicorp:main Oct 12, 2022
@jpogran
Copy link
Contributor

jpogran commented Oct 12, 2022

Apologies on the delay @bmalehorn , we merged this in and it it will be in the next release!

@radeksimko radeksimko mentioned this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants