Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFC Workspace View Filter Command #1452

Open
Tracked by #1449
jpogran opened this issue May 26, 2023 · 0 comments
Open
Tracked by #1449

TFC Workspace View Filter Command #1452

jpogran opened this issue May 26, 2023 · 0 comments
Labels
enhancement New feature or request terraform-cloud Features or bugs related to TFC integration in the editor

Comments

@jpogran
Copy link
Contributor

jpogran commented May 26, 2023

Expected User Experience

The TFC Website has two main filters: project and run statuses. Project is straightforward in that it filters by project id. Run statuses have 5 main filters: attention, error, held, and applied. These are 'fast and simple' choices to quickly see the more relevant workspaces.

Proposal

This presents the user with a QuickPick of options to filter the list of workspaces. Wording can be adjusted to exactly like TFC or suited to our extension context.

The Quickpick should list:

  • By Project
  • Needing Attention
  • With Errors
  • On Hold
  • Applied

The IconPath should match the TFC icon in the website. These have to match the existing VS Code Icon set, so there may need to be some thoughtful choice of similar icons to match.

User should be able to filter by Project AND/OR a run status. For example, all errored workspaces in the AccuTech project. They should not be able to filter on more than one status, for example on errored and applied. This may mean having two quickpicks or adding sufficient information to the single quickpick to explain and having validation inside the quickpick

image

Inspiration for this came from the Docker extension:
image

Alternative

The TFC website has a secondary filter with all types of statuses to choose. This allows you to filter on more than one status, whereas the pre-canned filters described above are rigid. We can support this by adding a second quickpick with all of these statuses and allow selecting more than one.

image

@jpogran jpogran added the terraform-cloud Features or bugs related to TFC integration in the editor label May 26, 2023
@dbanck dbanck self-assigned this May 26, 2023
@xiehan xiehan added this to the 2.27.0 (tentative) milestone Jun 2, 2023
@xiehan xiehan added the enhancement New feature or request label Jun 21, 2023
@dbanck dbanck removed this from the 2.29.0 (tentative) milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request terraform-cloud Features or bugs related to TFC integration in the editor
Projects
None yet
Development

No branches or pull requests

3 participants