Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement workspace filtering by project #1455

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented May 26, 2023

Implements parts of #1452


This PR adds filtering of workspaces by project.

UI

2023-06-02 12 13 59

API Error

CleanShot 2023-06-02 at 13 08 48@2x

@dbanck dbanck added the enhancement New feature or request label May 26, 2023
@dbanck dbanck self-assigned this May 26, 2023
@dbanck dbanck requested a review from a team as a code owner May 26, 2023 15:49
@dbanck dbanck marked this pull request as draft May 26, 2023 15:49
@dbanck dbanck force-pushed the f-tfc-project-filter branch 2 times, most recently from c2b2bf9 to 7cf729d Compare May 26, 2023 16:22
package.json Outdated Show resolved Hide resolved
src/providers/tfc/workspaceProvider.ts Outdated Show resolved Hide resolved
@dbanck dbanck force-pushed the f-tfc-project-filter branch 5 times, most recently from ade5e10 to 200f28c Compare June 2, 2023 10:13
@dbanck dbanck marked this pull request as ready for review June 2, 2023 11:09
@dbanck dbanck requested a review from a team June 2, 2023 11:23
@dbanck dbanck force-pushed the f-tfc-project-filter branch from c7278d7 to ddc1b02 Compare June 2, 2023 13:01
@dbanck dbanck force-pushed the f-tfc-project-filter branch from ddc1b02 to acfeeb5 Compare June 2, 2023 13:24
Comment on lines +91 to +93
// TODO? we could skip this request if a project filter is set,
// but with the addition of more filters, we could still get
// projects from different workspaces
Copy link
Contributor

@jpogran jpogran Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this to get the project name to display in the view. If the user selected a project, then we know the name both to filter and to add to the workspace, so wouldn't need to call out twice to get projects.

So, if user specifies project to filter, then use that project name to build the WorkspaceTreeItems. If not, call out and get a list of projects.

We can make this a followup ticket, so this is not stopping merging now.

@dbanck dbanck merged commit ed1f650 into f-tfc Jun 5, 2023
@dbanck dbanck deleted the f-tfc-project-filter branch June 5, 2023 09:22
dbanck added a commit that referenced this pull request Jun 19, 2023
* Contribute new filter icon and command

* Add search query parameter to projects endpoint

* Implement project quick pick

* Improve error messages
@jpogran jpogran added the terraform-cloud Features or bugs related to TFC integration in the editor label Jun 22, 2023
dbanck added a commit that referenced this pull request Jul 11, 2023
* Contribute new filter icon and command

* Add search query parameter to projects endpoint

* Implement project quick pick

* Improve error messages
jpogran pushed a commit that referenced this pull request Jul 11, 2023
* Contribute new filter icon and command

* Add search query parameter to projects endpoint

* Implement project quick pick

* Improve error messages
@jpogran jpogran mentioned this pull request Jul 12, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request terraform-cloud Features or bugs related to TFC integration in the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants