-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement workspace filtering by project #1455
Conversation
c2b2bf9
to
7cf729d
Compare
ade5e10
to
200f28c
Compare
c7278d7
to
ddc1b02
Compare
ddc1b02
to
acfeeb5
Compare
// TODO? we could skip this request if a project filter is set, | ||
// but with the addition of more filters, we could still get | ||
// projects from different workspaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this to get the project name to display in the view. If the user selected a project, then we know the name both to filter and to add to the workspace, so wouldn't need to call out twice to get projects.
So, if user specifies project to filter, then use that project name to build the WorkspaceTreeItems. If not, call out and get a list of projects.
We can make this a followup ticket, so this is not stopping merging now.
* Contribute new filter icon and command * Add search query parameter to projects endpoint * Implement project quick pick * Improve error messages
* Contribute new filter icon and command * Add search query parameter to projects endpoint * Implement project quick pick * Improve error messages
* Contribute new filter icon and command * Add search query parameter to projects endpoint * Implement project quick pick * Improve error messages
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Implements parts of #1452
This PR adds filtering of workspaces by project.
UI
API Error