Add API based filtering for organizations #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanck
force-pushed
the
f-tfc-filter-org-pick
branch
from
9f462ae to
426fe09
Compare
dbanck
force-pushed
the
f-tfc-filter-org-pick
branch
from
426fe09 to
7e825f7
Compare
We need this to open the browser for organziation creation
jpogran
approved these changes
Jun 12, 2023
src/utils/uiHelpers.ts
Outdated
| fetchItems(query?: string): Promise<vscode.QuickPickItem[]>; | ||
| } | ||
|
|
||
| export class APIQuickPick { |
There was a problem hiding this comment.
Would have expected this to be inside the terraformCloud folder as while it's a generic VSCode UI thing, its only really going to be used by the tfc stuff
dbanck
added a commit
that referenced
this pull request
Jun 19, 2023
* Build abstract api filtering quick pick * Use new APIQuickPick for project filter * Move TerraformCloudHost We need this to open the browser for organziation creation * Add search query parameter to organizations API * Improve APIQuickPick hide and show behavior * Implement OrganizationAPIResource * Use OrganizationAPIResource to pick an organization * Move uiHelpers file
jpogran
added
enhancement
dbanck
added a commit
that referenced
this pull request
Jul 11, 2023
* Build abstract api filtering quick pick * Use new APIQuickPick for project filter * Move TerraformCloudHost We need this to open the browser for organziation creation * Add search query parameter to organizations API * Improve APIQuickPick hide and show behavior * Implement OrganizationAPIResource * Use OrganizationAPIResource to pick an organization * Move uiHelpers file
jpogran
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Build abstract api filtering quick pick * Use new APIQuickPick for project filter * Move TerraformCloudHost We need this to open the browser for organziation creation * Add search query parameter to organizations API * Improve APIQuickPick hide and show behavior * Implement OrganizationAPIResource * Use OrganizationAPIResource to pick an organization * Move uiHelpers file
Merged
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds API-based filtering for organisations, based on work done for filtering projects in #1455.
As a result of discussion in Slack, it also adds the ability to open the browser to create organisations and refresh the list. This improves the workflow for users starting with an empty TFC account.
UX
Empty account
Some existing organizations
