Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch **/*.tf & **/*.tfvars by default #1095

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Watch **/*.tf & **/*.tfvars by default #1095

merged 1 commit into from
Jun 6, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented May 3, 2022 •
edited
Loading

Requires hashicorp/terraform-ls#15 (LS 0.28.0+)

Closes #1068

@radeksimko radeksimko added the enhancement New feature or request label May 3, 2022
@radeksimko radeksimko force-pushed the f-sync-tf-and-tfvars branch from 8f59e1e to 655fc2b Compare May 16, 2022 11:35
@radeksimko radeksimko mentioned this pull request May 31, 2022
Merged
@radeksimko radeksimko marked this pull request as ready for review May 31, 2022 14:46
@radeksimko radeksimko requested a review from a team as a code owner May 31, 2022 14:46
@radeksimko radeksimko self-assigned this May 31, 2022
@radeksimko radeksimko changed the title Watch **/*.tf & **/*.tfvars by default Watch **/*.tf & **/*.tfvars by default May 31, 2022
@radeksimko radeksimko added this to the 2.23.0 milestone May 31, 2022
@radeksimko
Copy link
Member Author

I'm going to pre-emptively schedule this for 2.23.0 but will not merge this yet until we have released LS 0.28.0 and start embedding that version in extension build, since there's unfortunately no capability negotiation for this LSP feature, so we'd otherwise end up sending change notifications which all error out.

@radeksimko radeksimko merged commit 3daa035 into main Jun 6, 2022
@radeksimko radeksimko deleted the f-sync-tf-and-tfvars branch June 6, 2022 07:18
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpogran jpogran jpogran approved these changes

Assignees

@radeksimko radeksimko

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.23.0
Development

Successfully merging this pull request may close these issues.

Watch **/*.tf and **/*.tfvars files for the language server
2 participants
@radeksimko @jpogran