Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Status indicator #1540

Closed
wants to merge 7 commits into from
Closed

Language Status indicator #1540

wants to merge 7 commits into from

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Jul 18, 2023

This sets a busy status when finding out the terraform version, which approximates a loading status for the extension because the request for status happens after all the other requests happen "in the background". So, we get a loading bar for the extension in the lower right hand corner.

Screen.Recording.2023-07-20.at.1.23.37.PM.mov

This sets a busy status when finding out the terraform version, which approximates a loading status for the extension because the request for status happens after all the other requests happen "in the background". So, we get a loading bar for the extension in the lower right hand corner.

We could make this a statusbarItem instead for better visibility and/or discoverability.
@jpogran jpogran self-assigned this Jul 18, 2023
hashicorp-copywrite bot and others added 2 commits July 18, 2023 16:34
Signed-off-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
@jpogran jpogran marked this pull request as ready for review July 20, 2023 17:31
@jpogran jpogran requested review from a team as code owners July 20, 2023 17:31
src/features/languageStatus.ts Outdated Show resolved Hide resolved
src/status/language.ts Outdated Show resolved Hide resolved
src/status/installedversion.ts Outdated Show resolved Hide resolved
@jpogran jpogran closed this Jul 25, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
@jpogran jpogran deleted the show_status branch August 30, 2023 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants