Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFC organization icon #1589

Merged
merged 2 commits into from
Oct 24, 2023
Merged

TFC organization icon #1589

merged 2 commits into from
Oct 24, 2023

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Oct 11, 2023

  • Add icon and 'TFC' prefix to statusBarItem text
  • Add organization name to Workspace view title
  • Add button to Workspace view to select organization

@jpogran jpogran added the terraform-cloud Features or bugs related to TFC integration in the editor label Oct 11, 2023
@jpogran jpogran self-assigned this Oct 11, 2023
@jpogran jpogran marked this pull request as ready for review October 12, 2023 14:53
@jpogran jpogran requested a review from a team as a code owner October 12, 2023 14:53
@jpogran jpogran linked an issue Oct 12, 2023 that may be closed by this pull request
1 task
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small nit

src/features/terraformCloud.ts Outdated Show resolved Hide resolved
- Add icon and 'TFC' prefix to statusBarItem text
- Add organization name to Workspace view title
- Add button to Workspace view to select organization
@jpogran jpogran force-pushed the tfc-organization-icon branch from 9e12ab1 to 164485d Compare October 23, 2023 15:32
@jpogran jpogran requested a review from dbanck October 23, 2023 15:35
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dbanck dbanck merged commit 4493709 into f-tfc Oct 24, 2023
17 checks passed
@dbanck dbanck deleted the tfc-organization-icon branch October 24, 2023 08:49
dbanck pushed a commit that referenced this pull request Oct 24, 2023
* Display selected TFC organization

- Add icon and 'TFC' prefix to statusBarItem text
- Add organization name to Workspace view title
- Add button to Workspace view to select organization

* parens
dbanck pushed a commit that referenced this pull request Nov 3, 2023
* Display selected TFC organization

- Add icon and 'TFC' prefix to statusBarItem text
- Add organization name to Workspace view title
- Add button to Workspace view to select organization

* parens
jpogran added a commit that referenced this pull request Nov 6, 2023
* Display selected TFC organization

- Add icon and 'TFC' prefix to statusBarItem text
- Add organization name to Workspace view title
- Add button to Workspace view to select organization

* parens
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
terraform-cloud Features or bugs related to TFC integration in the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TFC Organization status bar icon
2 participants