Fix plan and apply item tooltip #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of TFCRunTreeItem, any method that operates on a specific type of treeitem must check it's type. This is especially important in order to only resolve the tooltip for the RunTreeItem and not for Plan or Apply treeitems. This also makes the Plan and Apply buttons use the same codeicon.
jpogran
added
the
terraform-cloud
dbanck
approved these changes
Oct 13, 2023
dbanck
pushed a commit
that referenced
this pull request
Oct 24, 2023
With the introduction of TFCRunTreeItem, any method that operates on a specific type of treeitem must check it's type. This is especially important in order to only resolve the tooltip for the RunTreeItem and not for Plan or Apply treeitems. This also makes the Plan and Apply buttons use the same codeicon.
dbanck
pushed a commit
that referenced
this pull request
Nov 3, 2023
With the introduction of TFCRunTreeItem, any method that operates on a specific type of treeitem must check it's type. This is especially important in order to only resolve the tooltip for the RunTreeItem and not for Plan or Apply treeitems. This also makes the Plan and Apply buttons use the same codeicon.
jpogran
added a commit
that referenced
this pull request
Nov 6, 2023
With the introduction of TFCRunTreeItem, any method that operates on a specific type of treeitem must check it's type. This is especially important in order to only resolve the tooltip for the RunTreeItem and not for Plan or Apply treeitems. This also makes the Plan and Apply buttons use the same codeicon.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of TFCRunTreeItem, any method that operates on a specific type of treeitem must check it's type. This is especially important in order to only resolve the tooltip for the RunTreeItem and not for Plan or Apply treeitems.
This also makes the Plan and Apply buttons use the same codeicon.