Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TFC documentation #1620

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Update TFC documentation #1620

merged 1 commit into from
Nov 7, 2023

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Nov 6, 2023

This updates the README for the recent TFC updates:

  • Removes referencs to preview or prerelease
  • Records gifs using default VS Code theme, not light
  • Update login gif with correct sidebar icons
  • Runs view: Shows collapsed Runs, which when expanded show plan/apply details
  • Plan/Apply view: Updated to use the collapsible state to expose the plan and apply items, then clicking the button to download logs

@jpogran
Update TFC documentation
d23d178 
This updates the README for the recent TFC updates:

- Removes referencs to preview or prerelease
- Records gifs using default VS Code theme, not light
- Update login gif with correct sidebar icons
- Runs view: Shows collapsed Runs, which when expanded show plan/apply details
- Plan/Apply view: Updated to use the collapsible state to expose the plan and apply items, then clicking the button to download logs
@jpogran jpogran self-assigned this Nov 6, 2023
@jpogran jpogran marked this pull request as ready for review November 6, 2023 19:39
@jpogran jpogran requested a review from a team as a code owner November 6, 2023 19:40
radeksimko
radeksimko approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why but I see the GIFs in markdown rendered with some square-based texture. The texture is also visible on the pictures alone but not as distracting - only when zoomed in.

I'm not sure what to do, it may be just GitHub's own rendering but I am curious if you're seeing it as well?

Screenshot 2023-11-07 at 10 48 27

@jpogran
Copy link
Contributor Author

jpogran commented Nov 7, 2023

I'm not sure why but I see the GIFs in markdown rendered with some square-based texture. The texture is also visible on the pictures alone but not as distracting - only when zoomed in.

I'm going to merge as is, since it displays accurately enough in normal zoom and create a followup ticket to re-record with different software.

@jpogran jpogran merged commit 945237d into main Nov 7, 2023
19 checks passed
@jpogran jpogran deleted the update_tfc_docs branch November 7, 2023 14:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
@jpogran jpogran linked an issue Dec 18, 2023 that may be closed by this pull request
Update TFC Documentation #1608
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees

@jpogran jpogran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update TFC Documentation
2 participants
@jpogran @radeksimko