Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures on main #1659

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Fix test failures on main #1659

merged 3 commits into from
Jan 3, 2024

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Jan 2, 2024

We removed calling terraform init for integration tests in #1645 and also removed the Terraform installation altogether. It turns out that the formatting code action still requires Terraform.

This PR adds the installation of Terraform 1.6 to fix the testing issues on Windows and MacOS (the Ubuntu runner ships with Terraform installed).

VS Code automatically updates the workspace settings when the project is opened, so I've included that small change here as well.

@dbanck dbanck added the bug Something isn't working label Jan 2, 2024
@dbanck dbanck self-assigned this Jan 2, 2024
@dbanck dbanck force-pushed the b-increase-test-timout branch 2 times, most recently from 5da32fa to 7fef79e Compare January 2, 2024 11:46
dbanck added 2 commits January 2, 2024 14:07
Running the formatting code action requires Terraform
@dbanck dbanck force-pushed the b-increase-test-timout branch from 7fef79e to 2191e60 Compare January 2, 2024 13:07
@dbanck dbanck marked this pull request as ready for review January 2, 2024 13:48
@dbanck dbanck requested a review from a team as a code owner January 2, 2024 13:48
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the investigation and fix!

@dbanck dbanck merged commit f048279 into main Jan 3, 2024
19 checks passed
@dbanck dbanck deleted the b-increase-test-timout branch January 3, 2024 10:32
Copy link

github-actions bot commented Feb 3, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants