Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of tfcloud host #1673

Closed
wants to merge 4 commits into from

Conversation

Convez
Copy link
Contributor

@Convez Convez commented Jan 19, 2024

Issue: #1671

  • Add palette command for TFC logout vscode authentication provider (appears only after successful login):
    image
  • Add a provider for TFC Apis
  • Allow TFC host selection during login. Hosts already in TFC credentials file are displayed. Options for insertion of new hosts added:
    image
    image

N.B. Logging to a new hostname does not update the TFC credentials file (Maybe to be implemented in the future?)

@Convez Convez requested a review from a team as a code owner January 19, 2024 14:26
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 19, 2024

CLA assistant check
All committers have signed the CLA.

@Convez Convez force-pushed the feat/custom-tfcloud-host branch from 67d1c5c to 3ae76ca Compare January 22, 2024 09:04
hashicorp-copywrite bot and others added 3 commits January 22, 2024 09:05
Signed-off-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Convez , thank you so much for this work! I appreciate the time and effort put in here.

This is a great start! As it stands right now this does too much in one PR for us to merge as-is, so I would like to split up the work here to get some parts merged and we can collaborate on the design of other parts with you.

The stored credential file location handling fix is something I’d definitely like to get merged in, so can you please make that section a separate PR?

While I like the new UI around selecting TFC endpoints, I’d like to collaborate on the implementation. We see as many people generating user tokens via the TFC website as using the stored credentials file (from terraform login), so I want to spend some more time working on how that login workflow looks and works for the different use cases.

Changing most of the way the client authenticates is more than I’d like to change in this PR. I would like to work on a way that doesn’t alter the authentication parts while also accommodating the new selection methods.

Thanks again for the work put into this PR submission!

@Convez
Copy link
Contributor Author

Convez commented Jan 23, 2024

Hello @jpogran I agree there may be a lot going on in this PR.

I can create a new PR with the least possible changes to handle the credential file.

However what I would like to keep in the new PR (or integrate at a later time) is the fact I moved the API handling to its own class (apiProvider.tf).
I did that because the alternative would have been to have global non-const variables in the index.tf file that is deleted in this PR.

I'll open anyway a new PR as soon as I can with the last possible changes (without the apiProvider.tf)

@Convez
Copy link
Contributor Author

Convez commented Jan 31, 2024

Closing this PR, since I opened a simplified version of this

@Convez Convez closed this Jan 31, 2024
Copy link

github-actions bot commented Mar 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants