Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webdriver.io End to End Testing #1691

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Webdriver.io End to End Testing #1691

merged 3 commits into from
Mar 19, 2024

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Feb 12, 2024

Introduces new tests using webdriver.io as an integration testing framework for vscode extensions.

This aims to supplement, not replace the existing testing inside terraform-ls. There are some things that are difficult to test with the current testing framework, such as the UI, and the interaction between the extension and the language server.

This is a first step towards a more comprehensive testing strategy for the extension. As such, it is not expected to be perfect, and will likely need to be iterated on. Also, we likely will move the location, but want to get the initial setup in place.

@jpogran jpogran force-pushed the wdio-vscode branch 3 times, most recently from ecef82c to d02d9c6 Compare February 20, 2024 18:10
@jpogran jpogran marked this pull request as ready for review March 13, 2024 13:51
@jpogran jpogran requested a review from a team as a code owner March 13, 2024 13:51
package.json Outdated Show resolved Hide resolved
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @jpogran 🎉 I have a few smaller questions, but nothing that I'd see as blocking if we'd want to merge this today :)

test/specs/language/terraform.ts Show resolved Hide resolved
test/specs/language/terraform.ts Show resolved Hide resolved
test/specs/views/tfc.ts Outdated Show resolved Hide resolved
test/specs/views/tfc.ts Outdated Show resolved Hide resolved
jpogran and others added 3 commits March 19, 2024 10:11
Introduces new tests using webdriver.io as an integration testing framework for vscode extensions.

This aims to supplement, not replace the existing testing inside terraform-ls. There are some things that are difficult to test with the current testing framework, such as the UI, and the interaction between the extension and the language server.

This is a first step towards a more comprehensive testing strategy for the extension. As such, it is not expected to be perfect, and will likely need to be iterated on. Also, we likely will move the location, but want to get the initial setup in place.
@jpogran jpogran mentioned this pull request Mar 19, 2024
1 task
@jpogran jpogran requested review from ansgarm and dbanck March 19, 2024 14:19
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for setting this up

Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@jpogran jpogran merged commit 5a12233 into main Mar 19, 2024
18 checks passed
@jpogran jpogran deleted the wdio-vscode branch March 19, 2024 16:01
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants