-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webdriver.io End to End Testing #1691
Conversation
ecef82c
to
d02d9c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @jpogran 🎉 I have a few smaller questions, but nothing that I'd see as blocking if we'd want to merge this today :)
Introduces new tests using webdriver.io as an integration testing framework for vscode extensions. This aims to supplement, not replace the existing testing inside terraform-ls. There are some things that are difficult to test with the current testing framework, such as the UI, and the interaction between the extension and the language server. This is a first step towards a more comprehensive testing strategy for the extension. As such, it is not expected to be perfect, and will likely need to be iterated on. Also, we likely will move the location, but want to get the initial setup in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thanks for setting this up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Introduces new tests using webdriver.io as an integration testing framework for vscode extensions.
This aims to supplement, not replace the existing testing inside terraform-ls. There are some things that are difficult to test with the current testing framework, such as the UI, and the interaction between the extension and the language server.
This is a first step towards a more comprehensive testing strategy for the extension. As such, it is not expected to be perfect, and will likely need to be iterated on. Also, we likely will move the location, but want to get the initial setup in place.