Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webdriver.io tsconfig.json imports #1722

Closed
wants to merge 1 commit into from

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Mar 22, 2024

This adds the types to the package.json for the webdriver.io tests that were missed when moving the dependencies from the main package.json. This resolves errors in tsconfig.json when compiling.

This adds the types to the package.json for the webdriver.io tests that were missed when moving the dependencies from the main package.json. This resolves errors in tsconfig.json when compiling.
@jpogran jpogran self-assigned this Mar 22, 2024
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds the types to the package.json for the webdriver.io tests that were missed when moving the dependencies from the main package.json.

I'm not sure what you mean here, but I have no objection to adding these packages now.

@jpogran jpogran closed this Apr 3, 2024
@dbanck dbanck deleted the fix_webdriverio_packagejson branch April 9, 2024 09:09
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants