Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install native LS build for Apple Silicon (arm64) #563

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Conversation

radeksimko
Copy link
Member

This should not be merged until hashicorp/terraform-ls#350 is merged and released, i.e. when there is an actual darwin/arm64 build of LS available.

That PR is currently also on hold due to go-nv/goenv#164

@radeksimko radeksimko changed the title [HOLD] Install arm64 instead of amd64 for darwin [HOLD] Install native LS build for Apple Silicon (arm64) Feb 19, 2021
@pszypowicz
Copy link

Hi, just a kind reminder, that's all of your requirements seems to be meet :)

@radeksimko
Copy link
Member Author

@pszypowicz Thanks for the reminder.

Yes, the conditions I mentioned are met. We just had an internal conversation about how the unavailability of darwin/arm64 build of Terraform may affect the experience. There is certainly plan to release it soon, but not before significant number of official providers are released for that platform.

I'm sure that this could be worked around by passing -tf-exec flag to ensure that Terraform runs via Rosetta, but I don't think that's a great first-time UX (forcing users to change configuration to make it "just work"), so I think we're going to wait until the build is available.

@billinghamj
Copy link

Terraform itself is now fully natively available too! 😄 Along with most/all major providers 👌 I think it may be time!

@radeksimko
Copy link
Member Author

@billinghamj The team has plans to release native darwin/arm64 support soon, but it has not done so yet from what I know:
https://releases.hashicorp.com/terraform/0.15.0/

It is possible that you compiled Terraform for that platform yourself, or downloaded a binary compiled by a third party?
This may work, but it's not explicitly tested/supported by the maintaining team yet.

@billinghamj
Copy link

billinghamj commented Apr 27, 2021

A lot of people get terraform from brew, which has been distributing it compiled for arm64 for many months. Hashicorp's insistence to keep waiting for other dependencies has resulted in Terraform being - by far - the slowest to make progress on Apple Silicon support across all the tools I use

I mean no ill will to you, but as a policy it's really very frustrating and has unnecessarily delayed every single component of Terraform :\ Maybe if some of the engineers at Hashicorp used M1 machines, you might realise how bad it's been 😞

From a testing/supporting perspective, I don't know if you're aware, but Terraform is not stable on Rosetta 2 - it never has been. It's virtually unusable versus just running it with native builds, which - to my knowledge - haven't had a single issue. They just required Go 1.16

@radeksimko
Copy link
Member Author

Terraform 1.0.2 was released with darwin/arm64 support.

There is a bug fix release scheduled to go out soon, but I'll make sure this is part of the following release, most likely next week.

@radeksimko radeksimko changed the title [HOLD] Install native LS build for Apple Silicon (arm64) Install native LS build for Apple Silicon (arm64) Jul 16, 2021
@radeksimko radeksimko marked this pull request as ready for review July 16, 2021 05:53
@radeksimko radeksimko added the enhancement New feature or request label Jul 16, 2021
@radeksimko radeksimko requested a review from ansgarm July 19, 2021 06:51
@radeksimko radeksimko merged commit 9ca1d84 into main Jul 19, 2021
@radeksimko radeksimko deleted the apple-silicon branch July 19, 2021 17:02
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants