Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panel for module providers #850

Merged
merged 9 commits into from
Nov 17, 2021
Merged

Add panel for module providers #850

merged 9 commits into from
Nov 17, 2021

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Nov 12, 2021

This PR adds a new tree view panel in the explorer menu with the installed providers in the current module.

It depends on the language server PR hashicorp/terraform-ls#712

New panel, listing providers with the installed version:

CleanShot 2021-11-17 at 16 37 01@2x

No providers detected:

CleanShot 2021-11-17 at 16 35 20@2x

Providers not installed (yet):

CleanShot 2021-11-17 at 16 34 58@2x

Tooltip showing the required version:

CleanShot 2021-11-17 at 16 37 54@2x

Closes #701

@dbanck dbanck force-pushed the f-701-provider-panel branch 3 times, most recently from 97279fd to 3da6f04 Compare November 15, 2021 16:19
@dbanck dbanck marked this pull request as ready for review November 16, 2021 09:21
@dbanck dbanck requested a review from a team November 16, 2021 09:21
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from my two minor in-line comments this LGTM, but James has more VS Code related experience here so he may be able to provide more relevant feedback.

src/providers/providerProvider.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@radeksimko radeksimko requested a review from jpogran November 16, 2021 09:58
package.json Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
@dbanck dbanck force-pushed the f-701-provider-panel branch from 80a8535 to e46d7aa Compare November 17, 2021 14:41
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dbanck dbanck merged commit 7cc1d13 into main Nov 17, 2021
@dbanck dbanck deleted the f-701-provider-panel branch November 17, 2021 15:50
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display provider requirements/installed in the UI
3 participants