Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/setup-node to v2 #897

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Update actions/setup-node to v2 #897

merged 4 commits into from
Jan 10, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Jan 10, 2022

I’ve seen multiple canceled test runs on macos-latest in the setup-node step over the last couple of days. Upgrading to actions/setup-node@v2 should make things more reliable.

Additionally, actions/setup-node#338 added support for fetching the node version from a .npmrc file, so I was able to simplify most workflows.

@dbanck dbanck self-assigned this Jan 10, 2022
@dbanck dbanck requested a review from a team January 10, 2022 11:14
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! 👍🏻

Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@dbanck dbanck merged commit ec9d5dc into main Jan 10, 2022
@dbanck dbanck deleted the f-update-setup-node branch January 10, 2022 13:37
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants