Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Bump github.com/buildpacks/pack to v0.20.0 #2023

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Bump github.com/buildpacks/pack to v0.20.0 #2023

merged 1 commit into from
Aug 11, 2021

Conversation

aemengo
Copy link
Contributor

@aemengo aemengo commented Aug 11, 2021

Could we prioritize bumping pack within the codebase? Multiple users are reporting an edge case using the pack plugin on Mac M1 machines. This has been addressed in the latest release: v0.20.0

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 11, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aemengo aemengo mentioned this pull request Aug 11, 2021
Open
briancain
briancain reviewed Aug 11, 2021
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @aemengo , absolutely! I think there might be some unrelated package updates that were included in go.mod. Could you remove those? Otherwise looks good to me! I tested it with one of our pack plugin examples and seems to work ok. I don't have an M1 mac so I can't speak to if it fixes that 😅

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Bump github.com/buildpacks/pack to v0.20.0
ea8348a 
Signed-off-by: Anthony Emengo <aemengo@vmware.com>
briancain
briancain reviewed Aug 11, 2021
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a bunch of extra stuff still! I'm hoping if we remove those the extra go packages in go.sum will go away too.

go.mod Show resolved Hide resolved
go.mod Show resolved Hide resolved
@briancain
Copy link
Member

Oh wait @aemengo - apologies! no, I think you're good! I'm confused by what buildpack is adding 🤔 but I think this is buildpack adding these not you now. I will take a look now, because I see the same packages being added when I try to make the change. One moment.

briancain
briancain approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! Sorry for the go package weirdness 😄

@briancain briancain merged commit 91e7348 into hashicorp:main Aug 11, 2021
@aemengo
Copy link
Contributor Author

aemengo commented Aug 11, 2021

Thanks again! Sorry for the go package weirdness 😄

It's no problem at all! It took me much longer navigating these go.mod files than I'd like to admit. Thank you.

@aemengo aemengo deleted the bump-pack-v0.20.0 branch August 11, 2021 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briancain briancain briancain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aemengo @hashicorp-cla @briancain