Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-662: Remove installation of protoc #3039

Merged
merged 1 commit into from
Aug 30, 2023
Merged

H-662: Remove installation of protoc #3039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,6 @@ jobs:
with:
tool: just@1.13.0,cargo-hack@0.5.26,rust-script@0.23.0,clippy-sarif@0.3.7,sarif-fmt@0.3.7

# To be removed once https://github.com/open-telemetry/opentelemetry-rust/issues/934 is sorted
- name: Install Protoc
if: matrix.directory == 'apps/hash-graph'
uses: arduino/setup-protoc@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Check formatting
working-directory: ${{ matrix.directory }}
run: just format --check
Expand Down Expand Up @@ -225,13 +218,6 @@ jobs:
with:
tool: just@1.13.0,cargo-hack@0.5.26,cargo-nextest@0.9.37

# To be removed once https://github.com/open-telemetry/opentelemetry-rust/issues/934 is sorted
- name: Install Protoc
if: matrix.directory == 'apps/hash-graph'
uses: arduino/setup-protoc@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Install Python
if: matrix.directory == 'apps/engine'
uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1 # v4.7.0
Expand Down Expand Up @@ -330,13 +316,6 @@ jobs:
with:
tool: just@1.13.0,cargo-nextest@0.9.37,cargo-llvm-cov@0.5.9

# To be removed once https://github.com/open-telemetry/opentelemetry-rust/issues/934 is sorted
- name: Install Protoc
if: matrix.directory == 'apps/hash-graph'
uses: arduino/setup-protoc@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Run tests
working-directory: ${{ matrix.directory }}
run: just coverage --lcov --output-path lcov.info
Expand Down
3 changes: 0 additions & 3 deletions apps/hash-graph/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ WORKDIR /usr/local/src/apps/hash-graph
ARG PROFILE=production
ARG ENABLE_TEST_SERVER=no

# To be removed once https://github.com/open-telemetry/opentelemetry-rust/issues/934 is sorted
RUN apk add --no-cache make protobuf-dev

RUN --mount=type=cache,target=/usr/local/cargo/registry,sharing=locked \
--mount=type=cache,target=/usr/local/cargo/git,sharing=locked \
--mount=type=cache,target=/usr/local/src/apps/hash-graph/target,sharing=locked \
Expand Down