Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing alt property to image tags #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evaporei
Copy link

The img tags were missing the alt property which are important to blind people I guess, so I've added them.

However I don't know if they should be in portuguese or english, since the page has both languages. I've added in english since the whole code and properties are in english, but if you feel it should be in portuguese I can translate them 😉

@evaporei
Copy link
Author

evaporei commented Jul 19, 2020

Okay, I just realised that there are two index.html, one for each language 😅
I guess I will move the work done here to en/index.html and create similar alt properties in portuguese for the original index.html.

@evaporei evaporei force-pushed the add-alt-to-images branch from cbfc363 to 74a0c2d Compare July 19, 2020 16:32
@evaporei
Copy link
Author

Fixed, both portuguese and english versions have alt attribute on images 🎉

@ocaio ocaio requested a review from MarcoWorms July 20, 2020 14:35
@MarcoWorms
Copy link
Contributor

Hey @otaviopace thanks a lot for the contribution!

Since the use of the alt tag is supposed to help blind people it would be nice if they have a human-like readability, so instead of using "lisp-case" we should have the alt text in "Normal Case" (idk how is this case type is formally called haha)

Thanks @heyvito that have pointed out to the alt standard: https://www.w3.org/TR/WCAG20-TECHS/H37.html

I can make the commit that changes what you have done to use Normal Case, just let me know if i can take over the PR or if you want to do it by yourself ;)

Copy link
Contributor

@MarcoWorms MarcoWorms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change requested: replace casing for all instances of alt-text

example of how it is as of now:
alt="hash-menu-logo"

example of how it is expected to be:
alt="Hash Menu Logo"

@evaporei
Copy link
Author

Okay, I will change then 🙂

@heyvito
Copy link

heyvito commented Jul 20, 2020

Since the use of the alt tag is supposed to help blind people it would be nice if they have a human-like readability, so instead of using "lisp-case" we should have the alt text in "Normal Case" (idk how is this case type is formally called haha)

@MarcoWorms Just for curiosity's sake, it is called "Sentence case". Nothing special, and actually quite infuriating it doesn't have a better name. There you go. Now you know how it is formally called. 😛

@evaporei evaporei force-pushed the add-alt-to-images branch from 74a0c2d to 579013c Compare July 21, 2020 18:05
@evaporei
Copy link
Author

"Sentence case" also know as phrase 😂
So I've fixed the issues, you can review if the alt text is good.
Thanks for the knowledge btw 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants