-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing alt property to image tags #14
base: master
Are you sure you want to change the base?
Conversation
Okay, I just realised that there are two |
cbfc363
to
74a0c2d
Compare
Fixed, both portuguese and english versions have |
Hey @otaviopace thanks a lot for the contribution! Since the use of the alt tag is supposed to help blind people it would be nice if they have a human-like readability, so instead of using "lisp-case" we should have the alt text in "Normal Case" (idk how is this case type is formally called haha) Thanks @heyvito that have pointed out to the alt standard: https://www.w3.org/TR/WCAG20-TECHS/H37.html I can make the commit that changes what you have done to use Normal Case, just let me know if i can take over the PR or if you want to do it by yourself ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change requested: replace casing for all instances of alt-text
example of how it is as of now:
alt="hash-menu-logo"
example of how it is expected to be:
alt="Hash Menu Logo"
Okay, I will change then 🙂 |
@MarcoWorms Just for curiosity's sake, it is called "Sentence case". Nothing special, and actually quite infuriating it doesn't have a better name. There you go. Now you know how it is formally called. 😛 |
74a0c2d
to
579013c
Compare
"Sentence case" also know as phrase 😂 |
The
img
tags were missing thealt
property which are important to blind people I guess, so I've added them.However I don't know if they should be in portuguese or english, since the page has both languages. I've added in english since the whole code and properties are in english, but if you feel it should be in portuguese I can translate them 😉