-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batteries for templates #40
base: master
Are you sure you want to change the base?
Conversation
@martinklepsch, @Deraen let me know what do you think about optionally adding support for the template engines. |
I don't see myself using other than hiccup. Instead of making |
@Deraen I also probably will use Hiccup most of the times. But my motivation was to make it easier for other people to start. Also I feel like this implementation is quite flexible for extending. Because it works as before user may provide |
The things which bothers me is that if we are going to include some template engines we also need to add dependencies for them. I would like the dependencies were added only when the user is using the template engine. If engine is going to be set using keyword, we could map keyword to dependency before creating the pod. Btw. currently |
I like idea of mapping dependency to engine (and I agree with the argument about too much dependencies). Thanks for pointing out that |
Hi, @podviaznikov, What's the current status of this PR? |
Hi, @podviaznikov |
Include some batteries for rendering using template engine. Instead of requiring rendering function we accept two properties:
:template-engine
and:template-name
.Starting with https://github.com/yogthos/Selmer.
Plan is to add few more: Jade, Mustache.