Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal-install versions not most current #732

Closed
ysangkok opened this issue Jun 28, 2024 · 1 comment · Fixed by #736
Closed

cabal-install versions not most current #732

ysangkok opened this issue Jun 28, 2024 · 1 comment · Fixed by #736

Comments

@ysangkok
Copy link

ysangkok commented Jun 28, 2024

Looking at Cabal.hs, it seems that 3.10.2.0 is used when 3.10.3.0 could be used instead.

Also, 3.8 is not present, why?

Also, 3.6.2.0 is used even though GHCup has 3.6.2.0-p1 available with some patch applied. Is the p1 representable in Haskell-CI?

I am having a hard time understanding what this mapping is supposed to target.

EDIT: cabal-install-3.12.1.0 is now available in GHCup, so that could be added too

@phadej
Copy link
Collaborator

phadej commented Jul 1, 2024

To clarify the commit closing this issue: The mapping in Cabal module was there to map short versions to long ones for GHCUP, e.g. from 3.10 to 3.10.2.0.

I am having a hard time understanding what this mapping is supposed to target.

The mapping was above. hvr-ppa had packages named cabal-install-3.0, cabal-install-3.2 etc, and you got the most recent in the series through those. The mapping from short to full versions was needed for ghcup.

Also, 3.8 is not present, why?

I guess, it wasn't ever used. I don't remember which cabal-install issue was blocking it. (#606 wasn't merged, and we jumped to 3.9.0.0)

Also, 3.6.2.0 is used even though GHCup has 3.6.2.0-p1 available with some patch applied

The p1 version is not representable with Version datatype, it's not worth patching it. (ALso I have no idea what's the change in p1, which lessens the motivation)

EDIT: cabal-install-3.12.1.0 is now available in GHCup, so that could be added too

It will be. But you can also specify cabal-install-version: 3.12.1.0 if you wish already today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants