change unwrap to extract in overMatL' and overMatM' #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lsg6140 and I've found this bug in the
overMatL'
andoverMatM'
functions.A reduced example case we found is that
After loading this module in ghci, executing
invDiagR
andinvDiagC
produces these errors:By replacing
unwrap
withextract
in the definition ofoverMatL
andoverMatM
functions, we'vechecked that we have the expected results: