Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supports for ghc-8.10.4 #27

Closed
wants to merge 1 commit into from

Conversation

freizl
Copy link

@freizl freizl commented Mar 8, 2021

Add supports in GHC-8.10.4

  • adds 8.10.4 in travis build process
  • relax quickcheck version to 2.14.2
  • fix shadow variable binding warning
  • add HasMock instance for Fragment modifier

@fisx @phadej ^

- adds 8.10.4 in travis build process
- relax quickcheck version to 2.14.2
- fix shadow variable binding warning
- add `HasMock` instance for Fragment modifier
@freizl freizl marked this pull request as ready for review March 9, 2021 00:48
Copy link

@sorki sorki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested with recent snapshot, did the same bump locally before looking at PRs. I guess that Travis updates are not need anymore but it doesn't really matter as it probably should be replaced by follow-up PR with Actions like in the main repo.

@sorki sorki mentioned this pull request Aug 14, 2021
@sorki
Copy link

sorki commented Aug 14, 2021

Needed another base bump, so I've opened a follow-up PR #28 containing this one.

@freizl
Copy link
Author

freizl commented Aug 22, 2022

in favor of #28.

@freizl freizl closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants