Restore a few DHE_RSA ciphers #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all the DHE RSA ciphers gone, it was no longer possible to make SMTP STARTTLS connections to a server wtih RSA certs and no ECDHE support, just FFDHE4096 available. This sort of thing may be rare on the web, but is not nearly as rare in other application use cases.
This PR, just adds back the ciphers, without adding them to the default set, the application stil has to explicitly choose to include
ciphersuite_dhe_rsain the mix (which I did in the DANE scanner).If you'd prefer to not expose the list directly, and rather just include these in the default list, then tests would have to also change to enable DHE in supported groups when these ciphers are chosen...