Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant Hashable constraints on intersection* and union* #443

Closed
sjakobi opened this issue Apr 26, 2022 · 2 comments · Fixed by #478
Closed

Redundant Hashable constraints on intersection* and union* #443

sjakobi opened this issue Apr 26, 2022 · 2 comments · Fixed by #478

Comments

@sjakobi
Copy link
Member

sjakobi commented Apr 26, 2022

These functions don't compute any hashes, so we could consider removing the redundant constraints.
@treeowl
Copy link
Collaborator

treeowl commented Apr 26, 2022

Yank them, as far as I'm concerned. Did the previous intersection implementation need that?

@sjakobi
Copy link
Member Author

sjakobi commented Apr 27, 2022

Did the previous intersection implementation need that?

Yeah. It was based on unsafeInsert, so it was re-computing hashes.

rockbmb added a commit to rockbmb/unordered-containers that referenced this issue Oct 14, 2022
@rockbmb
[haskell-unordered-containers#443] Remove redundant Hashable constr…
f8e9a91 
…aints from `intersection.*, union.*`
@rockbmb rockbmb mentioned this issue Oct 14, 2022
Merged
sjakobi pushed a commit that referenced this issue Oct 14, 2022
@rockbmb
Remove redundant Hashable constraints from intersection.*, union.* (
6ae0580 
#478)

Closes #443.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@treeowl @sjakobi