'cabal check' should warn when there are no upper bounds in setup-depends

[23Skidoo]

wxc has the following custom-setup section:

custom-setup
  setup-depends: 
    base, 
    Cabal,
    bytestring,
    split,
    process,
    directory,
    filepath

That is, it says that its setup.hs works with any version of Cabal. However, it is lying - it actually fails to build against Cabal 2. We should warn about such obviously incorrect setup-depends and maybe even auto-rewrite the constraint on Cabal to < 2.

[23Skidoo]

Related: https://sourceforge.net/p/wxhaskell/bugs/112/

[hvr]

As discussed on IRC, it'd also make sense to validate that the lower bound on lib:Cabal is consistent with the spec-version specified in the .cabal file.

[grayjay]

As discussed on IRC, it'd also make sense to validate that the lower bound on lib:Cabal is consistent with the spec-version specified in the .cabal file.

#3751 is related to this.

[phadej]

If you review&accept my #4701, then I'd like to tackle this as a follow-up ;)

(yet, if it's for 2.0.1, then situation is tricker :( )

[phadej]

Note:

      +++ custom-setup
      +++     setup-depends: base -any
      +++                    Cabal -any
      +++                    cabal-doctest >=1.0.2 && <1.1

here I know that omitting upper bounds on Cabal is safe. Cabal dependency is needed because of #4288

[qnikst]

I'm going to work on this

[ulysses4ever]

Since #7409 has been merged, this probably can be closed. Cc @Mikolaj

[Mikolaj]

Right. High time. :)

Thank you again, @ulysses4ever, @qnikst and everybody who took part in the struggle.

[ulysses4ever]

Thanks a lot @Mikolaj for helping out with it!