Lookup main-is C sources in hs-source-dirs #10171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alt-romes
force-pushed
the
wip/romes/10168
branch
4 times, most recently
from
256b22e to
fc2abbd
Compare
geekosaur
approved these changes
Jul 3, 2024
sheaf
approved these changes
Jul 4, 2024
sheaf
reviewed
Jul 4, 2024
alt-romes
force-pushed
the
wip/romes/10168
branch
from
98cacd6 to
053528c
Compare
geekosaur
force-pushed
the
wip/romes/10168
branch
from
053528c to
9af4c0a
Compare
mergify
bot
added
the
merge delay passed
In the 2decb0e refactor we stopped looking for non-Haskell `main-is` files in the hs-source-dirs and other appropriate directories. This commit fixes that oversight. Even if it is not intuitive that main-is-C-sources are searched in the hs-source-dirs, we don't wish to break users relying on this behaviour as there does not exist that strong of a motivation to do so. Fixes haskell#10168 Co-authored-by: sheaf <sam.derbyshire@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 2decb0e refactor we stopped looking for non-Haskell
main-isfiles in the hs-source-dirs and other appropriate directories. This commit fixes that oversight.Even if it is not intuitive that main-is-C-sources are searched in the hs-source-dirs, we don't wish to break users relying on this behaviour as there does not exist that strong of a motivation to do so.
Fixes #10168
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: