Implement a haskell-suite compiler support #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes we'd much rather use haskell-packages than add more stuff to Cabal :) |
|
Looks nicely self-contained, so merging shouldn't be much of a risk. @dcoutts, can you take a look? |
|
Yes, looks OK. The bit about getting registered packages, and registering packages could probably share code with the Distribution.Simple.Program.HcPkg code, since it seems to share the same command line syntax. That HcPkg module does allow the program to be specified so it's fine for it to be the "${haskell-suite-compiler} pkg" syntax. |
|
OK, merging. @feuerbach If you want to refactor the code to use |
23Skidoo
added a commit
that referenced
this pull request
Oct 14, 2013
Implement a haskell-suite compiler support
|
Thanks! I'll look into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haskell suite adds a new compiler flavor to Cabal, except it is not tied to any particular compiler. Hopefully, this may be one of the last compiler flavors added to Cabal. (related: #57)
It is already used by the haskell suite interface generator.
(See http://documentup.com/haskell-suite/haskell-names#module-interfaces/generating-interfaces)
As far as I know, Fay is also interested in using haskell-packages, but the necessity to build a patched version of Cabal is a major hindrance for them.