Address remaining solver comments #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #2500 (comment).
Addresses #2500 (comment).
Addresses #2500 (comment) Addresses #2500 (comment)
(in the solver log) Addresses #2500 (comment)
Addresses #2500 (comment)
We previously recorded the canonical package and the instance of a link group separately, but it turns out we can always record these together: when we know one we know the other. This makes various choices a lot clearer. Addresses #2500 (comment) Addresses #2500 (comment) Addresses #2500 (comment) Addresses #2500 (comment) Addresses #2500 (comment) Addresses #2500 (comment) Addresses #2500 (comment) Addresses #2500 (comment) Addresses #2500 (comment) Addresses #2500 (comment) Addresses #2500 (comment)
|
Looks good. Go ahead and merge. |
23Skidoo
added a commit
that referenced
this pull request
Jun 1, 2015
Address remaining solver comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised, this addresses the remaining comments on the independent and setup goals PR set (#2487, #2488, #2500, #2504, #2514, #2515, #2530, and #2531). Most of these commits just add some comments or rearrange some code.
There are really only two actual changes:
lgInstanceandlgCanonin the link verification, as discussed with @kosmikus .Once this PR is merged I believe the setup dependencies are ready to go and there are no remaining comments to be addressed.
/pinging also @dcoutts .