Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using smaller package ids on Windows (see #3430) #3431

Merged
merged 1 commit into from
May 17, 2016
Merged

Try using smaller package ids on Windows (see #3430) #3431

merged 1 commit into from
May 17, 2016

Commits on May 14, 2016

  1. Try using smaller package ids on Windows 

    On Windows we have serious problems with path lengths. Windows imposes a
maximum path length of 260 chars, and even if we can use the windows
long path APIs ourselves, we cannot guarantee that ghc, gcc, ld, ar, etc
etc all do so too.

So our only choice is to limit the lengths of the paths, and the only
real way to do that is to limit the size of the 'InstalledPackageId's
that we generate. We do this by truncating the package names and
versions and also by truncating the hash sizes.

Truncating the package names and versions is technically ok because they
are just included for human convenience, the full source package id is
included in the hash.

Truncating the hash size is disappointing but also technically ok. We
rely on the hash primarily for collision avoidance not for any securty
properties (at least for now).
    @dcoutts
    dcoutts committed May 14, 2016
    Configuration menu
    Copy the full SHA
    541ac88 View commit details
    Browse the repository at this point in the history