Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move doc/ to the top-level of the repository #6970

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jul 16, 2020

No description provided.

@phadej phadej merged commit 7118ea0 into haskell:master Jul 16, 2020
@phadej phadej deleted the move-doc-to-top branch July 16, 2020 16:15
@jhrcek
Copy link
Contributor

jhrcek commented Jul 18, 2020

@phadej This seems to have broken the references in Cabal/Cabal.cabal

I'm getting build errors when building cabal library locally

~/Devel/github.com/haskell/cabal> (cd Cabal; cabal install)
cabal: filepath wildcard 'doc/bugs-and-stability.rst' does not match any
files.

Also these instructions for building users guide no longer work, probably the cd Cabal fixes it.

@phadej
Copy link
Collaborator Author

phadej commented Jul 19, 2020

@jhrcek ok, so you hit an issue #6955 would caught. I took a note.

@phadej
Copy link
Collaborator Author

phadej commented Jul 20, 2020

@jhrcek fixed

@jhrcek
Copy link
Contributor

jhrcek commented Jul 20, 2020

@phadej Thank you, the (cd Cabal; cabal install) step for building cabal library now works fine for me.

But the build steps for users guide are still broken:
https://github.com/haskell/cabal/blob/master/doc/README.md#how-to-build-it

  1. The cd Cabal should probably be removed
  2. When I run make users-guide at project's root it basically erases the contents of the doc/buildinfo-fields-reference.rst

It's not blocking me or anything, just wanted to make you aware of the effect this recent move of users guide had.
I'd do the PR myself, but I'm not sure how to fix 2.

@phadej
Copy link
Collaborator Author

phadej commented Jul 20, 2020

@jhrcek that should be fixed now as well. Thanks again for reporting.

@phadej phadej added this to the 3.6.0.0-rc1 milestone Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants