-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Paths_ module with qualified Data.List.last import #7650
Conversation
@alexbiehl: this is great for a quickfix, but what do you think about trying not to use Prelude at all and then adding a test that indeed turns off Prelude and compiles Paths_ so that don't stumble into this problem again? Also, whatever happend to the previous PR? :) |
turning of prelude can be done with |
After some problems to build cabal from this commit, i've tried it with policeman package and it worked 👍 |
This is the minimum change (so minimum risk to break things) which fixes it so imo we could merge this and do the definitive fix in another one on top of it |
Thanks @jneira for trying it on the Kowainik packages!! |
@alexbiehl: ping? we should probably stick this into 3.6.2 RSN, so what's your recommendation about the wider context? |
@Mikolaj My recommendation is to merge as is. Refactoring the code to avoid Prelude will take more time and I'd need to spend substantial time on it. |
Got it. Let's do that. |
@Mergifyio backport 3.6 |
Command
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. many thanks for the fix
Command
|
Generate Paths_ module with qualified Data.List.last import (backport #7650)
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!