-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list-bin support for scripts. #7925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Splendid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect companion of your main pr improving cabal script, including a regression test, thanks!
@bacchanalia wrote:
Issue 1: I checked the test output but it does not contain the path to the binary. I'd expect that Anyhow, the test should really include the produced executable path, and I think it didn't due to #8400.
Issue 2: There is documentation of Would you be able to supply this documentation now to close #7986? |
Indeed I missed the test output problem and the above suggestions make sense to me. |
|
||
env <- getTestEnv | ||
cacheDir <- getScriptCacheDirectory $ testCurrentDir env </> "script.hs" | ||
assertOutputContains cacheDir res |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bacchanalia : I don't understand how this assertOutputContains
succeeds with above output (that does not contain something resembling a cacheDir
). But apparently it does. How?
Small PR to add script support for list-bin. It includes a test.
Because of #7774, I do not believe there is any documentation that needs to be updated.
Related: #7073