Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cabal-check testsuite: add Package/File tests #8250

Merged
merged 83 commits into from
Jul 1, 2022
Merged

cabal-check testsuite: add Package/File tests #8250

merged 83 commits into from
Jul 1, 2022

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Jun 23, 2022 •
edited
Loading

These tests cover all cabal check checks not already present in #8248.

It is another step towards #8211; the total number of tests added in the two patches is 106 105.

Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@ffaf1 ffaf1 force-pushed the cabal-check-testsuite-old-fields branch from 8d0eb5e to 29bd336 Compare June 23, 2022 12:26
@ffaf1 ffaf1 mentioned this pull request Jun 24, 2022
Merged
3 tasks
@ffaf1 ffaf1 force-pushed the cabal-check-testsuite-old-fields branch 8 times, most recently from 95b5e5a to df30f37 Compare June 27, 2022 14:39
@ffaf1 ffaf1 changed the title cabal-check testsuite: add “fields” tests cabal-check testsuite: add “ConfigurePackage” tests Jun 27, 2022
@ffaf1 ffaf1 force-pushed the cabal-check-testsuite-old-fields branch 3 times, most recently from 64d1ecc to 0bac9de Compare June 28, 2022 16:54
@ffaf1 ffaf1 changed the title cabal-check testsuite: add “ConfigurePackage” tests cabal-check testsuite: add Package/File tests Jun 30, 2022
@ffaf1 ffaf1 marked this pull request as ready for review June 30, 2022 12:55
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Jun 30, 2022

I will squash + merge me this time!

andreasabel
andreasabel approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Since all these are just tests, I won't read the 300 files line by line, but just give a bona fide approval.

ffaf1 added 20 commits July 1, 2022 14:37
@ffaf1
(cabal check) Add “Unknown extension” test
ea3ba05
@ffaf1
(cabal check) Add “Language as extension” test
5f44c65 
Languages cannot be listed in `default-extensions`.
@ffaf1
(cabal check) Add “Deprecated extension” test
71730c2
@ffaf1
(cabal check) Add “No synopsis” test
196f0ef
@ffaf1
(cabal check) Add “No description” test
a98385c
@ffaf1
(cabal check) Add “No category” test
cb1200d
@ffaf1
(cabal check) Add “No maintainer” test
f5884b2
@ffaf1
(cabal check) Add “Short description” test
ea2d851 
`description` should be longer than `synopsis`.
@ffaf1
(cabal check) Add “Invalid tested with range” test
7c4adda
@ffaf1
(cabal check) Add “Internal library” test
8cb879b 
On impossible version ranges for internal libraries.
@ffaf1
(cabal check) Add BOM test
8ca98b7
@ffaf1
(cabal check) Add “Name mismatch” test
64f0559
@ffaf1
(cabal check) Add “Missing .cabal” test
3f2a8ba
@ffaf1
(cabal check) Add “Missing license file” test
54dbef3
@ffaf1
(cabal check) Add “No setup file” test
c6cfa3c
@ffaf1
(cabal check) Add “No configure file” test
cc46086
@ffaf1
(cabal check) Add “Local paths” check
fe81390
@ffaf1
(cabal check) Add “Missing VCS info” test
560e049
@ffaf1
(cabal check) Add “Partial extension match” test
0250b4a
@ffaf1
(cabal check) Add “Filename too long” check
50138ec
@ffaf1 ffaf1 force-pushed the cabal-check-testsuite-old-fields branch from 6a419e2 to 50138ec Compare July 1, 2022 12:38
@ffaf1 ffaf1 added the squash+merge me Tell Mergify Bot to squash-merge label Jul 1, 2022
@mergify mergify bot merged commit 1cfe7c4 into haskell:master Jul 1, 2022
@ffaf1 ffaf1 mentioned this pull request Jul 1, 2022
Closed
4 tasks
@ffaf1 ffaf1 deleted the cabal-check-testsuite-old-fields branch July 1, 2022 17:10
@ffaf1 ffaf1 mentioned this pull request Sep 22, 2022
Merged
4 tasks
@parsonsmatt parsonsmatt mentioned this pull request Nov 7, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@andreasabel andreasabel andreasabel approved these changes

Assignees
No one assigned
Labels
Cabal: tests/package-tests cabal-install: cmd/check squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffaf1 @andreasabel @ulysses4ever