Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable everfailing assertion #8821

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Disable everfailing assertion #8821

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a13d14b
Disable everfailing assertion
ulysses4ever Feb 28, 2023
3f55208
Fix unused parameter
ulysses4ever Feb 28, 2023
2ca5daa
Merge branch 'master' into disable-assert-t6006
mergify[bot] Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions cabal-install/src/Distribution/Client/ProjectPlanning.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,19 +235,24 @@ sanityCheckElaboratedConfiguredPackage
-> ElaboratedConfiguredPackage
-> a
-> a
sanityCheckElaboratedConfiguredPackage sharedConfig
sanityCheckElaboratedConfiguredPackage _sharedConfig
elab@ElaboratedConfiguredPackage{..} =
(case elabPkgOrComp of
ElabPackage pkg -> sanityCheckElaboratedPackage elab pkg
ElabComponent comp -> sanityCheckElaboratedComponent elab comp)

-- The assertion below fails occasionally for unknown reason
-- so it was muted until we figure it out, otherwise it severely
-- hinders our ability to share and test development builds of cabal-install.
-- Tracking issue: https://github.com/haskell/cabal/issues/6006
--
-- either a package is being built inplace, or the
-- 'installedPackageId' we assigned is consistent with
-- the 'hashedInstalledPackageId' we would compute from
-- the elaborated configured package
. assert (elabBuildStyle == BuildInplaceOnly ||
elabComponentId == hashedInstalledPackageId
(packageHashInputs sharedConfig elab))
-- . assert (elabBuildStyle == BuildInplaceOnly ||
-- elabComponentId == hashedInstalledPackageId
-- (packageHashInputs sharedConfig elab))

-- the stanzas explicitly disabled should not be available
. assert (optStanzaSetNull $
Expand Down