Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add the ExtendedLiterals extension (backport of #8992)" #9260

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

Kleidukos
Copy link
Member

This reverts commit 9faa4db.

fixes #9258

@geekosaur
Copy link
Collaborator

I am curious as to why the original added NoDeepSubsumption only, though.

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the vim config stuff was missing the negative versions of some extensions.

BTW, do we need to update the changelogs, too? Namely, remove the entry for this PR.

@geekosaur
Copy link
Collaborator

I saw a deleted-file entry for something in changelogs.d, so it's already handled.

@Mikolaj
Copy link
Member

Mikolaj commented Sep 14, 2023

And backport or forwardport the changelogs change (not the revert PRs).

@Kleidukos
Copy link
Member Author

And backport or forwardport the changelogs change (not the revert PRs).

@Mikolaj Why? 3.12 is a major version, no need to forward-port the commit revert?

@Mikolaj
Copy link
Member

Mikolaj commented Sep 14, 2023

And backport or forwardport the changelogs change (not the revert PRs).

@Mikolaj Why? 3.12 is a major version, no need to forward-port the commit revert?

Hah, that's what I'm saying. Not the commit revert. Forwardport the global changelogs change that I mentioned in my previous comment.

@Kleidukos Kleidukos merged commit 4712f85 into haskell:3.10 Sep 20, 2023
@Kleidukos Kleidukos deleted the revert-extensions-3.10.2.0 branch September 20, 2023 07:41
@Mikolaj
Copy link
Member

Mikolaj commented Sep 20, 2023

I can still see ExtendedLiterals in https://github.com/haskell/cabal/blob/master/release-notes/Cabal-3.10.2.0.md.

Edit: and the same on branch 3.10: https://github.com/haskell/cabal/blob/3.10/release-notes/Cabal-3.10.2.0.md

@Kleidukos
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants