Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test requirement to PR template #9413

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Nov 6, 2023

Adding test becomes a checkmark instead of “bonus points”.


Template Β: This PR does not modify cabal behaviour (documentation, tests, refactoring, etc.)

Include the following checklist in your PR:

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/pull_request_template.md Outdated Show resolved Hide resolved
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect (until next data points arrive:).

@ffaf1 ffaf1 added the merge me Tell Mergify Bot to merge label Nov 7, 2023
@andreabedini
Copy link
Collaborator

👍

@ffaf1 ffaf1 closed this Nov 10, 2023
@ffaf1 ffaf1 deleted the pr-template branch November 10, 2023 12:21
@ffaf1 ffaf1 restored the pr-template branch November 10, 2023 13:26
@ffaf1 ffaf1 reopened this Nov 10, 2023
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Nov 12, 2023
Adding test becomes a checkmark instead of “bonus points”.
@mergify mergify bot merged commit 2dad49a into haskell:master Nov 12, 2023
44 checks passed
@ffaf1 ffaf1 deleted the pr-template branch November 12, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants